Upgrade RuboCop related gems #3367
Conversation
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
| # Maintain the original backtrace so that debugging cops that are breaking is easier, but re-raise as a | ||
| # different error class | ||
| internal_error = InternalRuboCopError.new(error) | ||
| internal_error.set_backtrace(error.backtrace) | ||
| raise internal_error |
There was a problem hiding this comment.
While trying to understand if the bug I was seeing was in our code or in RuboCop's, I noticed that we were discarding the original backtrace for internal RuboCop errors.
That's not good, because we want to help people fix bugs in cops and not just point the backtrace to our own code. Here I changed to use set_backtrace to ensure that the original backtrace is preserved, which helps debugging problematic cops.
| @@ -452,10 +452,10 @@ suite("Client", () => { | |||
| ); | |||
|
|
|||
| const expected = [ | |||
| "# typed: strict", | |||
There was a problem hiding this comment.
There were some changes in regards to the safety of some auto corrects. I changed the example, just to ensure that formatting actually runs on this example.
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
6 times, most recently
from
1bf88c8 to
dc3352c
Compare
| - rubocop-sorbet | ||
| - rubocop-md | ||
| - rubocop-minitest | ||
| - rubocop-rake | ||
|
|
||
| require: | ||
| - ./lib/rubocop/cop/ruby_lsp/use_language_server_aliases |
There was a problem hiding this comment.
Could we migrate these as plugins?
vinistock
force-pushed
the
03-28-upgrade_rubocop_related_gems
branch
from
dc3352c to
5f936b3
Compare
|
Just FYI, something in the new RuboCop versions is breaking our ability to show documentation links as part of the quick fixes, which is why I haven't shipped this yet. I have not managed to figure out what changed, but it looks this call to base_url_for is not consistently returning I suspect that's a symptom and not the root cause. Something may have changed in how settings are taken into account. |
Motivation
Upgrade the rest of the outdated development gems, all related to RuboCop. There's a bug fix for the RuboCop add-on in these upgrades, so that we stop seeing an argument error while developing.